Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace deprecated pkg_resources API #55

Merged
merged 10 commits into from
Feb 11, 2025

Conversation

luisfelipec95
Copy link
Contributor

Description

pkg_resources (from setuptools) is deprecated and will be removed in future Python versions.
The new implementation uses importlib.resources, which is the recommended alternative and is fully available in Python 3.9+.

Testing instructions

1, Create a Sumac environment using Tutor or TVM.
2. Install flow-control-xblock using this branch you can follow the official tutor documentation.
3. In a course of study:
Navigate to Settings -> Advanced Settings and go to Advanced Module List settings.
Add:
image
4. Create Unit -> Advance ->flow-control

Other Information

openedx/public-engineering#273

@luisfelipec95 luisfelipec95 requested a review from a team as a code owner February 5, 2025 06:33
Copy link

@DeimerM DeimerM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked this xblock in the release sumac instance and everything seems to work very well https://studio.sumac.releases.edunext.link/container/block-v1:OpenedX+101+2025+type@vertical+block@c4a002c6d6784e66aeddba1a78236333

Copy link
Contributor

@magajh magajh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@luisfelipec95 luisfelipec95 merged commit 570b73a into master Feb 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants