Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove env.development import in paragon-webpack-plugin #2

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

dcoa
Copy link
Collaborator

@dcoa dcoa commented Mar 26, 2024

``This PR aims to fix the report about bundling development configurations in production code.

For context about this issue, you can reference JIRA-Card

How to test

  1. In your tutor environment create an inline plugin with
hooks.Filters.ENV_PATCHES.add_items(
    [
        (
            "mfe-dockerfile-post-npm-install",
            """
    RUN npm install --save-dev '@edx/frontend-build@git+https://github.com/eduNEXT/frontend-build.git#dcoa/fix-env-vars'
    """
        ),
    ]
)
  1. create a new image tutor images build mfe
  2. Run the environment and check there is not Order History inside the user menu
    image

@dcoa dcoa requested a review from bra-i-am March 26, 2024 15:10
Copy link

@bra-i-am bra-i-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no Order History inside the user menu!

@dcoa dcoa merged commit 8ecf2c4 into ednx-release/css-variables Apr 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants