Drop support for Python 3.8 and replace pkg_resources with importlib.resources #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeimerM
reviewed
Feb 7, 2025
There was a problem hiding this comment.
Hi @luisfelipec95 I saw in other PRs that you added importlib-resources in requirements/base.in but I can't see it on this PR, isn't this requirement needed?
|
I checked this xblock in the release sumac instance and everything seems to work very well https://studio.sumac.releases.edunext.link/container/block-v1:OpenedX+101+2025+type@vertical+block@25d1f39f06924f46ae5007acba34ac20 |
Thanks @DeimerM, You're right, I have already updated the other PRs since it's not necessary to add importlib-resources in Python 3.11. |
magajh
reviewed
Feb 11, 2025
Co-authored-by: Maga Giorgianni <maria.jaimes@edunext.co>
DeimerM
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pkg_resources (from setuptools) is deprecated and will be removed in future Python versions.
The new implementation uses importlib.resources, which is the recommended alternative and is fully available in Python 3.9+.
Testing instructions
1, Create a Sumac environment using Tutor or TVM.
2. Install xblock-imagesgallery using this branch you can follow the official tutor documentation.
3. In a course of study:
Navigate to Settings -> Advanced Settings and go to Advanced Module List settings.
Add:
4. Create Unit -> Advance ->imagesgallery
Other Information
openedx/public-engineering#273