Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

env_kind.go: load image into kind cluster #73

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

leonnicolas
Copy link

@leonnicolas leonnicolas commented Nov 16, 2024

This commit load the image into the kind cluster with

kind load docker-image <image-name>

We need to do this if the image is not in a public registry.
It also stops using docker manifest inspect.
Instead we should rather check if the image is present locally.
If so we can load it into the cluster, otherwise we have to pull it first.

Signed-off-by: leonnicolas leonloechner@gmx.de

This commit load the image into the kind cluster with
```
kind load docker-image <image-name>
```
We need to do this if the image is not in a public registry.
Honestly, the purpose of the `preLoadImage()` function is not clear to me.

Signed-off-by: leonnicolas <leonloechner@gmx.de>
Pull only the image if it isn't present on the machine and always load
it into the cluster.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant