Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HCM Admin Console v0.3 & Microplan v0.1 Release UI Code changes #1823
HCM Admin Console v0.3 & Microplan v0.1 Release UI Code changes #1823
Changes from 250 commits
be26161
e9849a8
8e9c5a9
729a249
40282f5
48c5847
cd68a5a
9e83a2e
74949f3
0b6af4c
2760c50
a5d7c67
2cecab5
8161371
1fdc55b
d20fccd
1c7965e
6eb526a
fa87589
8a5c270
e717315
b1094e1
d29e461
993e202
62b7995
e4e0a5d
c501b6d
c18e61a
ecc1e36
fbfda55
6e94a55
9a959b7
61179f7
88a1433
e32aad6
d0408da
86ca571
94608ae
4bf3640
2cb78eb
707c0ba
ac8f506
dd96fd4
f25f0aa
9887205
7381b59
a81fc9a
cd57493
5bc4a38
3b476b3
4bb88f2
8ec7882
938a25c
0539c64
db168ed
04ec9d4
28c5ea4
4055e28
eb972fc
b99b3fa
b911619
51dbc45
af070ec
a6da672
aa672b1
5b8e5e0
1ca8f46
4c1e42f
bc60ede
d297c75
eb719e7
61d683d
27592bb
4a7c338
a68bf4a
e1767bf
706044d
c3a7bfc
f933a58
da0cdd5
36b17dc
86d4be5
229c853
b52a5e3
acec032
d22da23
ae23195
7c366dc
7c0ba40
26a98f9
8217b85
591b351
21df7f3
c72dd14
01451ee
0de2079
670e78a
328454a
8a75f0c
589d276
c112a09
2e27ce7
872b286
4a4e762
a7fae3f
cc683ed
427f95f
fd7b142
d33a49a
120ebe5
3c0f86f
a4f03f5
d29dc9b
51fc69c
2061379
de6b430
ddf3225
88f4ada
976fa6e
e107a4a
f6fd573
0343381
cfda909
cd3f2b2
fc83566
8451ab2
bfbe14c
583516e
e94d8d3
b024006
aaeb4fa
743ef7f
922c40b
91fc3bb
4bbdf0b
85ab966
59efc94
2d453f3
82f25b2
7c65754
afe7b3f
27244a9
8e72bfd
fb8dd57
6c60185
872a811
cc92022
62fc006
0ae1d36
7f2cf05
24540b1
0c09a8a
b7d5634
e5b3552
32f482b
7924f59
3e214a9
6fe9381
98aa7ba
71918af
1c6a5dd
266a3a9
546978a
3621550
c53e85a
3c9a50a
f9f43bc
cdf8bb7
006aa49
5c6d702
d40eb1d
5ab0b40
2bf688a
f2552b6
09103ff
226aebc
b4c5ce0
38ae76d
d9aeb78
55da0c2
7a2afde
b79b30e
50834f5
65427f9
106c3db
60d32cb
d986b65
001718b
134ae7c
61dd04e
b53f239
0348915
ea33a14
3325f7d
70b49e6
7f2bd71
7aef8f2
652a965
8699ab6
be0fc8a
144e200
c64b251
dc6d329
4108c50
cff5b4b
9a0f4f8
d7a8602
de257b5
3af5290
19b1a4e
6350019
6636d8a
ee914b3
91f1737
dd57af3
fe45e60
cf596aa
9d9d03c
2baaf32
b14b6d2
977495b
81c1c5c
6b6d101
5de6d4b
97a5d00
1bd0353
94dafd2
9b635a2
e3ce6c0
8f2f6fe
acbfd80
618b9c4
d1a4c20
ac1899c
0322ed0
9f8fb7d
5f6239c
cf0f1fb
405c9ec
a209418
f4fe24e
1589bf3
e7b54f8
d9a3080
b92a13e
b1d50dd
15f58ff
81a3cec
549c9e6
e5f6b5b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Consider scoping the default owner pattern.
The pattern
.*
matches everything in the repository, which means @jagankumar-egov will be notified for all changes. Consider if this broad scope is necessary or if it could be more targeted.A more specific approach could be:
This still acts as a catch-all but is more conventional in CODEOWNERS files.
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Add documentation for the ownership structure.
To improve maintainability and clarity, consider adding comments to explain:
Example structure:
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Consider revising or removing the multi-line comment
The comment from lines 1-8 appears to be misplaced or redundant. It refers to "The above code," which might not be accurate. Comments should provide meaningful insights rather than restating the code. Consider updating the comment to be more precise or removing it if unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Consider documenting the base image selection rationale
There are two base image options (one commented out). Consider documenting the reason for choosing
egovio
overghcr.io
to help with future maintenance decisions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Pin package versions for reproducible builds
While specifying a minimum git version is good for security, using exact version pins would ensure reproducible builds.
📝 Committable suggestion
🧰 Tools
🪛 Hadolint (2.12.0)
[warning] 4-4: Pin versions in apk add. Instead of
apk add <package>
useapk add <package>=<version>
(DL3018)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Consider standardizing Node.js memory limit configuration
The codebase shows inconsistent memory limits across different Dockerfiles:
These varying configurations suggest different memory requirements for different services. Consider:
🔗 Analysis chain
Verify Node.js memory limit configuration
The 4792MB memory limit seems specific. Consider documenting why this exact value was chosen and verify if it's sufficient for your build requirements.
Let's search for any documentation or similar memory configurations in the codebase to understand if this value is consistently used or documented somewhere.
Let's examine the actual memory values used across different Dockerfiles to see if this is a consistent configuration or if there are variations that might provide insights about the chosen value.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 0
Script:
Length of output: 129
Script:
Length of output: 541
Script:
Length of output: 590
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Refactor build steps for better maintainability
Several improvements can be made to the build process:
🧰 Tools
🪛 Hadolint (2.12.0)
[warning] 13-13: Use WORKDIR to switch to a directory
(DL3003)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Validate nginx configuration during build
Consider adding a configuration test step to catch any nginx configuration issues during the build phase.
COPY --from=build /app/web/build ${WORK_DIR}/ COPY --from=build /app/web/core/nginx.conf /etc/nginx/conf.d/default.conf +RUN nginx -t
📝 Committable suggestion
🧹 Nitpick (assertive)
Enhance security configuration
Consider implementing these security best practices:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Improve command output efficiency
The echo command with command substitution can be simplified.
📝 Committable suggestion
🧰 Tools
🪛 Shellcheck (0.10.0)
[style] 17-17: Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.
(SC2005)