BUGFIX/HCMPRE-2253 : Fixed Button Issue in PopDataTable Screen (#2195)

[Swathi-eGov]

Choose the appropriate template for your PR:

Feature PR

Feature Request

JIRA ID

Module

Description

Related Issues

---

Bugfix PR

Bugfix Request

JIRA ID

Module

Description

Root Cause

Related Issues

---

Release PR

Summary by CodeRabbit

• New Features

  • Enhanced alerts now display with improved SVG visuals for a more polished look.

• Bug Fixes

  • Status counts in the inbox refresh automatically following workflow updates, ensuring up-to-date information.
  • Error messages in workflow processes are now clearer and more informative.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request makes two distinct changes. In one component, a new property showAlertAsSvg is added to the PopUp inside the BoundarySelection component to enable SVG-based alerts. In another component, the PopInbox now calls fetchStatusCount() within the onSuccess callback of WorkflowCommentPopUp to refresh status counts after workflow updates, and its error handling is refined to extract the error message properly.

Changes

File(s)	Change Summary
health/.../BoundarySelection.js	Added new property showAlertAsSvg set to true in the PopUp component to display alerts as SVG.
health/.../PopInbox.js	Inserted a call to fetchStatusCount() in the onSuccess callback of WorkflowCommentPopUp and refined error message extraction in error handling.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant WCP as WorkflowCommentPopUp
    participant PI as PopInbox
    participant SS as StatusService

    User->>WCP: Trigger workflow update
    WCP->>PI: onSuccess callback invoked
    PI->>SS: Call fetchStatusCount()
    SS-->>PI: Return updated status count

Loading

Possibly related PRs

• BUGFIX/HCMPRE-2253 : Fixed Button Issue in PopDataTable Screen #2195: Modifies the showAlertAsSvg property in the PopUp component, directly related to the changes in BoundarySelection.
• Popup fix #1958: Adjusts properties of the PopUp component in a different context, providing a code-level connection with these modifications.

Suggested reviewers

• jagankumar-egov
• nipunarora-eGov

Poem

I'm a happy rabbit, hopping with glee,
Code carrots and changes, a sight to see.
SVG alerts now shine so clear, 🥕
Status counts update, never fear.
With a bounce and a hop, I cheer each line,
Celebrating these fixes, so perfectly divine!

Tip

🌐 Web search-backed reviews and chat

• We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
• You can disable this feature by setting web_search: false in the knowledge_base settings.
• Please share any feedback in the Discord discussion.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 71f636a and dee7972.

📒 Files selected for processing (2)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/BoundarySelection.js (1 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.js`: check

**/*.js: check

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/BoundarySelection.js
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js

📓 Learnings (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (2)

Learnt from: rachana-egov
PR: egovernments/DIGIT-Frontend#1837
File: health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js:559-561
Timestamp: 2024-11-15T10:15:57.370Z
Learning: In `PopInbox.js`, error handling for the `onError` callback in `WorkflowCommentPopUp` is handled within the component, so explicit error handling in the parent component is unnecessary.

Learnt from: rachana-egov
PR: egovernments/DIGIT-Frontend#1832
File: health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js:592-594
Timestamp: 2024-11-14T12:48:23.024Z
Learning: In `PopInbox.js`, when integrating the `ConfirmationPopUp` component, error handling for API failures is managed internally within the component, so explicitly passing an `onError` prop is not necessary.

🔇 Additional comments (2)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (1)

792-792: LGTM! Consistent data refresh after workflow update.

The addition of fetchStatusCount() in the success callback ensures that status counts are refreshed after editing population data, maintaining data consistency with other workflow updates in the component.

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/BoundarySelection.js (1)

134-134: Verify PopUp component's support for showAlertAsSvg prop.

Please ensure that the PopUp component from @egovernments/digit-ui-components supports the showAlertAsSvg prop.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.