BUG/HCMPRE-2260: upload data mapping screen add/edit bug fixes

[nabeelmd-eGov]

Choose the appropriate template for your PR:

Feature PR

Feature Request

JIRA ID

Module

Description

Related Issues

---

Bugfix PR

Bugfix Request

JIRA ID

Module

Description

Root Cause

Related Issues

---

Release PR

Summary by CodeRabbit

• New Features
  • Improved data filtering to ensure only active mapping entries display based on selected criteria.
  • Enhanced row count and pagination logic for smoother navigation and accurate data display.
  • Added sortable columns to the data table for improved interactivity.
  • Refined error messaging to provide clear and structured feedback to users.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The changes update the data handling in the UploadDataMapping component. The reducer logic now conditionally filters data based on specific categories ("HCM_UPLOAD_USER_MAPPING" and "HCM_UPLOAD_FACILITY_MAPPING") to return only active entries, and recalculates totalRows accordingly when filters are applied. In addition, pagination now includes a safeguard ensuring the currentPage does not exceed the available pages. Minor UI enhancements include making columns sortable and refining error handling by structuring error messages.

Changes

File	Changes Summary
health/micro-ui/.../campaign-manager/src/components/UploadDataMapping.js	Enhanced filtering for 'currentCategories' to include only active entries; updated totalRows calculation based on filtered data; added pagination safeguard; enabled sortable columns; improved error handling formatting.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant C as UploadDataMapping Component
    participant F as Filter Logic
    participant P as Pagination Manager
    participant UI as UI Renderer

    U->>C: Submit data with/without filter
    C->>F: Apply filtering on currentCategories
    F-->>C: Return filtered active entries
    C->>P: Validate current page vs totalRows
    P-->>C: Confirm valid page/page adjustment
    C->>UI: Update table with filtered & paginated data
    UI-->>U: Render updated view

Loading

Possibly related PRs

• BUGFIX/HCMPRE-1730: Fixes pagination in mapping table #2078: Modifies UploadDataMapping.js to enhance data filtering and pagination logic.
• BUGFIX/HCMPRE-1242: Status active/inactive and pagination bug fix #2160: Adjusts the data handling logic with a focus on managing filteredData and pagination.
• BUGFIX/HCMPRE-1243: added check for empty upload  #2056: Enhances data processing in UploadDataMapping.js by adding pagination safeguards and additional checks (e.g., for empty uploads).

Suggested reviewers

• jagankumar-egov
• nipunarora-eGov

Poem

Hey, I'm a clever rabbit on the code trail,
Hopping through logic with a nibble and a tale.
Active entries only, filtered with care,
Pagination neat, no page left to spare.
Sorting and error checks make my day bright,
A little bunny cheers in pure delight!
🥕 Happy coding, the rabbit sings tonight.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e5154ff and 51d1f64.

📒 Files selected for processing (1)

• health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadDataMapping.js (18 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.