Issue #71 Jurisdiction based validation for property update #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the following changes to check if the assessor/assignee is in the jurisdiction of the property
-> Added HrmsService to fetch employee data in a particular jurisdiction
-> Added appropriate data models - Employee, HRMSResponse and Locality to store the fetched response
-> Modified Property model to get Locality as a field
-> Modified PropertyValidator to validate based on juridiction at 2 levels while updating property. First for the assessor to be in the same jurisdiction and the assignee to be in the same jurisdiction as well
-> Modified application.properties for jurisdiction flag and hrms endpoint