-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add created/updated reporting test vectors and fix implementations #222
Merged
carlos-romano
merged 8 commits into
main
from
feat/update-reporting-test-vectors-and-fix-implementations
Jan 16, 2025
Merged
Add created/updated reporting test vectors and fix implementations #222
carlos-romano
merged 8 commits into
main
from
feat/update-reporting-test-vectors-and-fix-implementations
Jan 16, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
carlos-romano
commented
Jan 15, 2025
- Add created/updated test vectors and fix implementations.
- Fix all places where we use $variables, as it looks like we should not include the "$".
…es where we use $ like , as it looks like $ shouldn't be used
c7b0104
to
b1192d8
Compare
carlos-romano
commented
Jan 15, 2025
carlos-romano
commented
Jan 15, 2025
carlos-romano
commented
Jan 15, 2025
greywolve
reviewed
Jan 16, 2025
greywolve
reviewed
Jan 16, 2025
greywolve
reviewed
Jan 16, 2025
greywolve
reviewed
Jan 16, 2025
greywolve
reviewed
Jan 16, 2025
tests/integration/vectors/reports/tiny/consume_authorization_once-1.json
Outdated
Show resolved
Hide resolved
greywolve
previously approved these changes
Jan 16, 2025
bamzedev
reviewed
Jan 16, 2025
bamzedev
approved these changes
Jan 16, 2025
greywolve
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.