Skip to content

Commit

Permalink
Allow disabling default addons with Auto Mode (#8165)
Browse files Browse the repository at this point in the history
  • Loading branch information
artem-nefedov authored Jan 30, 2025
1 parent 00788c8 commit 7bf721a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions pkg/ctl/cmdutils/configfile.go
Original file line number Diff line number Diff line change
Expand Up @@ -485,18 +485,18 @@ func validateDryRunOptions(cmd *cobra.Command, incompatibleFlags []string) error
return nil
}

// validateBareCluster validates a cluster for unsupported fields if VPC CNI is disabled.
// validateBareCluster validates a cluster for unsupported fields if VPC CNI and Auto Mode is disabled.
func validateBareCluster(clusterConfig *api.ClusterConfig) error {
if !clusterConfig.AddonsConfig.DisableDefaultAddons || slices.ContainsFunc(clusterConfig.Addons, func(addon *api.Addon) bool {
if !clusterConfig.AddonsConfig.DisableDefaultAddons || clusterConfig.IsAutoModeEnabled() || slices.ContainsFunc(clusterConfig.Addons, func(addon *api.Addon) bool {
return addon.Name == api.VPCCNIAddon
}) {
return nil
}
if clusterConfig.HasNodes() || clusterConfig.IsFargateEnabled() || clusterConfig.Karpenter != nil || clusterConfig.HasGitOpsFluxConfigured() ||
(clusterConfig.IAM != nil && ((len(clusterConfig.IAM.ServiceAccounts) > 0) || len(clusterConfig.IAM.PodIdentityAssociations) > 0)) {
return errors.New("fields nodeGroups, managedNodeGroups, fargateProfiles, karpenter, gitops, iam.serviceAccounts, " +
"and iam.podIdentityAssociations are not supported during cluster creation in a cluster without VPC CNI; please remove these fields " +
"and add them back after cluster creation is successful")
"and iam.podIdentityAssociations are not supported during cluster creation in a cluster without VPC CNI if Auto Mode is disabled; " +
"please remove these fields and add them back after cluster creation is successful")
}
return nil
}
Expand Down
4 changes: 2 additions & 2 deletions pkg/ctl/cmdutils/configfile_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -501,8 +501,8 @@ var _ = Describe("cmdutils configfile", func() {
}).Load()
if e.expectErr {
Expect(err).To(MatchError("fields nodeGroups, managedNodeGroups, fargateProfiles, karpenter, gitops, iam.serviceAccounts, " +
"and iam.podIdentityAssociations are not supported during cluster creation in a cluster without VPC CNI; please remove these fields " +
"and add them back after cluster creation is successful"))
"and iam.podIdentityAssociations are not supported during cluster creation in a cluster without VPC CNI if Auto Mode is disabled; " +
"please remove these fields and add them back after cluster creation is successful"))
} else {
Expect(err).NotTo(HaveOccurred())
}
Expand Down

0 comments on commit 7bf721a

Please sign in to comment.