refactor: drop custom fsync implementation (#42066)

* refactor: drop custom fsync implement

upstream is using F_FULLFSYNC on darwin
call stdlib f.sync and remove custom fsync implementation

* lint: fix linting errors

* Update util.go

libbeat/statestore/backend/memlog/diskstore.go

@@ -217,7 +217,7 @@ func (s *diskstore) Close() error {
 		// always sync log file on ordinary shutdown.
 		err := s.logBuf.Flush()
 		if err == nil {
-			err = syncFile(s.logFile)
+			err = s.logFile.Sync()
 		}
 		s.logFile.Close()
 		s.logFile = nil
@@ -380,7 +380,7 @@ func (s *diskstore) checkpointTmpFile(tempfile string, states map[string]entry)
 		return "", err
 	}
 
-	if err = syncFile(f); err != nil {
+	if err = f.Sync(); err != nil {
 		return "", err
 	}
 
@@ -658,7 +658,7 @@ func writeMetaFile(home string, mode os.FileMode) error {
 		return err
 	}
 
-	if err := syncFile(f); err != nil {
+	if err := f.Sync(); err != nil {
 		return err
 	}
 

libbeat/statestore/backend/memlog/util.go

@@ -18,11 +18,9 @@
 package memlog
 
 import (
-	"errors"
 	"io"
 	"os"
 	"runtime"
-	"syscall"
 )
 
 // countWriter keeps track of the amount of bytes written over time.
@@ -37,12 +35,6 @@ func (c *countWriter) Write(p []byte) (int, error) {
 	return n, err
 }
 
-var _ = isRetryErr
-
-func isRetryErr(err error) bool {
-	return errors.Is(err, syscall.EINTR) || errors.Is(err, syscall.EAGAIN)
-}
-
 // trySyncPath provides a best-effort fsync on path (directory). The fsync is required by some
 // filesystems, so to update the parents directory metadata to actually
 // contain the new file being rotated in.
@@ -53,7 +45,7 @@ func trySyncPath(path string) {
 	}
 	defer f.Close()
 	//nolint:errcheck // ignore error
-	syncFile(f)
+	f.Sync()
 }
 
 // pathEnsurePermissions checks if the file permissions for the given file match wantPerm.