Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Osquerybeat: Fix missing result values when the value can not be converted into expected type #33587

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

aleksmaus
Copy link
Contributor

@aleksmaus aleksmaus commented Nov 6, 2022

What does this PR do?

Preserve the field original value in the result even if it osquerybeat the type conversion in the case where the column value type doesn't match the actual value type.

For more detailed information refer to the
#33586

Why is it important?

Fixes the issue with missing column value in the query results. In this particular case the queries that use group_concat function are affected.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

How to test this PR locally

Run query

SELECT group_concat(DISTINCT port) as data FROM listening_ports

Verify the one result is returned

Related issues

Screenshots

Verified it's working after the change
Screen Shot 2022-11-05 at 10 14 55 PM

@aleksmaus aleksmaus added bug Team:Asset Mgt backport-v8.4.0 Automated backport with mergify backport-v8.5.0 Automated backport with mergify labels Nov 6, 2022
@aleksmaus aleksmaus requested a review from scunningham November 6, 2022 02:18
@aleksmaus aleksmaus requested a review from a team as a code owner November 6, 2022 02:18
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 6, 2022
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-06T02:18:32.574+0000

  • Duration: 45 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 1632
Skipped 0
Total 1632

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@aleksmaus aleksmaus merged commit 89a1134 into elastic:main Nov 7, 2022
mergify bot pushed a commit that referenced this pull request Nov 7, 2022
…erted into expected type (#33587)

(cherry picked from commit 89a1134)
mergify bot pushed a commit that referenced this pull request Nov 7, 2022
…erted into expected type (#33587)

(cherry picked from commit 89a1134)
aleksmaus added a commit that referenced this pull request Nov 8, 2022
…erted into expected type (#33587) (#33594)

(cherry picked from commit 89a1134)

Co-authored-by: Aleksandr Maus <aleksandr.maus@elastic.co>
aleksmaus added a commit that referenced this pull request Nov 8, 2022
…erted into expected type (#33587) (#33595)

(cherry picked from commit 89a1134)

Co-authored-by: Aleksandr Maus <aleksandr.maus@elastic.co>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.4.0 Automated backport with mergify backport-v8.5.0 Automated backport with mergify bug Team:Asset Mgt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants