-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run auditbeat integration tests on non-PR builds #41919
Conversation
We want to run Auditbeat integration tests regularly on non-PR (main branch builds). This will help ensure problems are not missed in the various integration test systems, and help prepare for adding Ubuntu 24.04 to the list of officially supported systems.
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
@mjwolf A few questions...
|
I've now run the integration tests as part of this PR's build: https://buildkite.com/elastic/auditbeat/builds/10970#01946704-8e6e-41f0-8ece-e7c055674f69
These integration tests are not new, and I've never seen any flakyness with them, but I have run them a few more times with this PR to ensure there are no failures.
The runtime is about 20 min, but as they run parallel with other build steps, they don't add any additional time to the build: https://buildkite.com/elastic/auditbeat/builds/10970/waterfall |
/test |
@elastic/ingest-eng-prod Can you please take a look at this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We want to run Auditbeat integration tests regularly on non-PR (main branch builds). This will help ensure problems are not missed in the various integration test systems, and help prepare for adding Ubuntu 24.04 to the list of officially supported systems. (cherry picked from commit 8122c43)
…2656) We want to run Auditbeat integration tests regularly on non-PR (main branch builds). This will help ensure problems are not missed in the various integration test systems, and help prepare for adding Ubuntu 24.04 to the list of officially supported systems. (cherry picked from commit 8122c43) Co-authored-by: Michael Wolf <michael.wolf@elastic.co>
Proposed commit message
Run Auditbeat integration tests regularly on all non-PR in CI (i.e. main branch builds).
This will help ensure problems are not missed in the various integration test systems, and help prepare for adding Ubuntu 24.04 to the list of officially supported systems for Auditbeat.
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
None