Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run auditbeat integration tests on non-PR builds #41919

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

mjwolf
Copy link
Contributor

@mjwolf mjwolf commented Dec 5, 2024

Proposed commit message

Run Auditbeat integration tests regularly on all non-PR in CI (i.e. main branch builds).

This will help ensure problems are not missed in the various integration test systems, and help prepare for adding Ubuntu 24.04 to the list of officially supported systems for Auditbeat.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

None

We want to run Auditbeat integration tests regularly on non-PR (main branch builds).

This will help ensure problems are not missed in the various integration test systems, and
help prepare for adding Ubuntu 24.04 to the list of officially supported systems.
@mjwolf mjwolf added Auditbeat release-note:skip The PR should be ignored when processing the changelog Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution backport-8.x Automated backport to the 8.x branch with mergify labels Dec 5, 2024
@mjwolf mjwolf requested a review from a team as a code owner December 5, 2024 19:25
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 5, 2024
@mergify mergify bot assigned mjwolf Dec 5, 2024
@rowlandgeoff
Copy link
Contributor

@mjwolf A few questions...

  • Can you please point to an existing Buildkite run that included those test steps?
  • Are we sure that they're stable (not flaky) before we add them to every non-PR build?
  • How long is their runtime?

@mjwolf
Copy link
Contributor Author

mjwolf commented Jan 15, 2025

@mjwolf A few questions...

  • Can you please point to an existing Buildkite run that included those test steps?

I've now run the integration tests as part of this PR's build: https://buildkite.com/elastic/auditbeat/builds/10970#01946704-8e6e-41f0-8ece-e7c055674f69

  • Are we sure that they're stable (not flaky) before we add them to every non-PR build?

These integration tests are not new, and I've never seen any flakyness with them, but I have run them a few more times with this PR to ensure there are no failures.

  • How long is their runtime?

The runtime is about 20 min, but as they run parallel with other build steps, they don't add any additional time to the build: https://buildkite.com/elastic/auditbeat/builds/10970/waterfall

@mjwolf
Copy link
Contributor Author

mjwolf commented Jan 15, 2025

/test

@andrewkroh
Copy link
Member

@elastic/ingest-eng-prod Can you please take a look at this PR?

Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkroh andrewkroh merged commit 8122c43 into elastic:main Feb 10, 2025
20 checks passed
mergify bot pushed a commit that referenced this pull request Feb 10, 2025
We want to run Auditbeat integration tests regularly on non-PR (main
branch builds).

This will help ensure problems are not missed in the various integration
test systems, and help prepare for adding Ubuntu 24.04 to the list of
officially supported systems.

(cherry picked from commit 8122c43)
andrewkroh pushed a commit that referenced this pull request Feb 10, 2025
…2656)

We want to run Auditbeat integration tests regularly on non-PR (main
branch builds).

This will help ensure problems are not missed in the various integration
test systems, and help prepare for adding Ubuntu 24.04 to the list of
officially supported systems.

(cherry picked from commit 8122c43)

Co-authored-by: Michael Wolf <michael.wolf@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auditbeat backport-8.x Automated backport to the 8.x branch with mergify :integrations release-note:skip The PR should be ignored when processing the changelog Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants