Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run packaging snapshot with prereleases #42326

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

dliappis
Copy link
Contributor

Proposed commit message

This fixes a small bug related to #42304 (example failure link).
When we (manually) trigger prerelease builds (by setting VERSION_QUALIFIER="...") we only want them to trigger staging builds and skip snapshot builds.

Related issues

https://github.com/elastic/ingest-dev/issues/4857

@dliappis dliappis added the bug label Jan 16, 2025
@dliappis dliappis self-assigned this Jan 16, 2025
@dliappis dliappis requested a review from a team as a code owner January 16, 2025 15:32
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 16, 2025
@botelastic
Copy link

botelastic bot commented Jan 16, 2025

This pull request doesn't have a Team:<team> label.

Copy link
Contributor

mergify bot commented Jan 16, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @dliappis? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Jan 16, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 16, 2025
This fixes a small bug related to elastic#42304 ; when we (manually)
trigger prerelease builds (by setting VERSION_QUALIFIER="...") we
only want them to trigger staging builds and skip snapshot builds.
@dliappis dliappis force-pushed the dont-run-snapshot-with-prerelease branch from 3c93ba2 to 4a97cd2 Compare January 16, 2025 15:45
Copy link
Contributor

@rowlandgeoff rowlandgeoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dliappis dliappis added backport-7.17 Automated backport to the 7.17 branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify labels Jan 16, 2025
@dliappis dliappis merged commit a122a9f into elastic:main Jan 17, 2025
9 checks passed
mergify bot pushed a commit that referenced this pull request Jan 17, 2025
This fixes a small bug related to #42304 ; when we (manually)
trigger prerelease builds (by setting VERSION_QUALIFIER="...") we
only want them to trigger staging builds and skip snapshot builds.

(cherry picked from commit a122a9f)

# Conflicts:
#	.buildkite/packaging.pipeline.yml
mergify bot pushed a commit that referenced this pull request Jan 17, 2025
This fixes a small bug related to #42304 ; when we (manually)
trigger prerelease builds (by setting VERSION_QUALIFIER="...") we
only want them to trigger staging builds and skip snapshot builds.

(cherry picked from commit a122a9f)
mergify bot pushed a commit that referenced this pull request Jan 17, 2025
This fixes a small bug related to #42304 ; when we (manually)
trigger prerelease builds (by setting VERSION_QUALIFIER="...") we
only want them to trigger staging builds and skip snapshot builds.

(cherry picked from commit a122a9f)
mergify bot pushed a commit that referenced this pull request Jan 17, 2025
This fixes a small bug related to #42304 ; when we (manually)
trigger prerelease builds (by setting VERSION_QUALIFIER="...") we
only want them to trigger staging builds and skip snapshot builds.

(cherry picked from commit a122a9f)
jlind23 pushed a commit that referenced this pull request Jan 17, 2025
…#42330)

* Don't run packaging snapshot with prereleases (#42326)

This fixes a small bug related to #42304 ; when we (manually)
trigger prerelease builds (by setting VERSION_QUALIFIER="...") we
only want them to trigger staging builds and skip snapshot builds.

(cherry picked from commit a122a9f)

# Conflicts:
#	.buildkite/packaging.pipeline.yml

* fix merge conflicts

---------

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
dliappis added a commit that referenced this pull request Jan 17, 2025
This fixes a small bug related to #42304 ; when we (manually)
trigger prerelease builds (by setting VERSION_QUALIFIER="...") we
only want them to trigger staging builds and skip snapshot builds.

(cherry picked from commit a122a9f)

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
dliappis added a commit that referenced this pull request Jan 17, 2025
This fixes a small bug related to #42304 ; when we (manually)
trigger prerelease builds (by setting VERSION_QUALIFIER="...") we
only want them to trigger staging builds and skip snapshot builds.

(cherry picked from commit a122a9f)

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
dliappis added a commit that referenced this pull request Jan 17, 2025
This fixes a small bug related to #42304 ; when we (manually)
trigger prerelease builds (by setting VERSION_QUALIFIER="...") we
only want them to trigger staging builds and skip snapshot builds.

(cherry picked from commit a122a9f)

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify bug needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants