[8.x](backport #42848) enhancement(4534): removed encryption and encrytion related logic from segments #42891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
mergify
bot
requested review from
mauri870 and
faec
and removed request for
a team
botelastic
bot
added
the
needs_team
github-actions
bot
added
the
Team:Elastic-Agent-Data-Plane
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
removed
the
needs_team
faec
approved these changes
Feb 27, 2025
|
This pull request has not been merged yet. Could you please review and merge it @kaanyalti? 🙏 |
…m segments (#42848) * enhancement(4534): removed encryption and encrytion related logic from segments * enhancement(4534): removed encryption related tests and config * enhancement(4534): updated documentation * enhancement(4534): ran make update * enhancement(4534): updated changelog * enhancement(4534): replaces rand with rand/v2 * enhancement(4534): remove commented config var (cherry picked from commit 42c4aa0)
kaanyalti
force-pushed
the
mergify/bp/8.x/pr-42848
branch
from
a4b5541 to
7af793a
Compare
mauri870
approved these changes
Mar 6, 2025
|
@kaanyalti Feel free to merge this backport PR. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Removed encryption, encryption related tests, and all the encryption logic from the v2 of diskqueue. The encryption package uses cipher.NewCTR which is not implemented for windows in Microsoft's fork of golang.
Checklist
[] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
This is an automatic backport of pull request #42848 done by [Mergify](https://mergify.com).