-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(libbeat): mitigate race condition in ratelimit processor #42966
Open
mauri870
wants to merge
12
commits into
elastic:main
Choose a base branch
from
mauri870:ratelimit-data-race
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+52
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
92dac6e
to
31eb212
Compare
31eb212
to
2a24573
Compare
belimawr
reviewed
Feb 28, 2025
changelog/fragments/1740762770-fix-race-conditions-in-rate-limit-processor.yaml
Outdated
Show resolved
Hide resolved
3f60d1d
to
d1f22f4
Compare
/test |
1 similar comment
/test |
belimawr
reviewed
Mar 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just waiting for CI to be green.
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-active-all
Automated backport with mergify to all the active branches
bugfix
Team:Elastic-Agent-Data-Plane
Label for the Agent Data Plane team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This PR fixes race conditions on the ratelimit processor. The race conditions can only manifest with configurations that have a global ratelimit processor and multiple inputs. Fixed by adding a mutex to the bucket struct.
During benchmarking, I also noticed an unnecessary allocation occurring in the hot path. Removing this allocation resulted in a 25% performance improvement. While locks have an inherent cost, in this scenario, the performance gain offsets that cost.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Run filebeat with a global ratelimit processor under the race detector: