Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows 2025 for unit test steps for main branch #43054

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oakrizan
Copy link
Contributor

@oakrizan oakrizan commented Mar 5, 2025

Proposed commit message

Based on Support Matrix Windows 2025 should be added for filebeat and metricbeat only. Updated Extended Windows unit test group with additional step per beats mentioned above.
Creating a separate PR for main branch and skipping for other branches, since pipeline definitions on 8.x, 8.18 and 9.0 has no test collector plugin enabled.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Logs

Buildkite filebeat build: https://buildkite.com/elastic/filebeat/builds/14290#0195681f-36ae-41a2-b537-8fdf66f31fba
Buiildkite metricbeat build: https://buildkite.com/elastic/beats-metricbeat/builds/14794#0195681f-3e35-474d-aa8c-ab51ce70a664

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 5, 2025
Copy link
Contributor

mergify bot commented Mar 5, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @oakrizan? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 5, 2025
@oakrizan oakrizan added backport-8.x Automated backport to the 8.x branch with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch and removed backport-8.x Automated backport to the 8.x branch with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch labels Mar 5, 2025
@oakrizan
Copy link
Contributor Author

oakrizan commented Mar 5, 2025

/test

@oakrizan oakrizan added the backport-skip Skip notification from the automated backport with mergify label Mar 5, 2025
@oakrizan oakrizan requested review from dliappis, v1v and pazone March 6, 2025 11:22
@oakrizan oakrizan marked this pull request as ready for review March 6, 2025 12:29
@oakrizan oakrizan requested a review from a team as a code owner March 6, 2025 12:29
@v1v
Copy link
Member

v1v commented Mar 6, 2025

Please, backport #42998 instead of creating a new PR from scratch. It's not ideal, but I prefer we keep semantic with the backports, so if a PR already is merged with he content and needs to be backported back to other branches, let's use mergify. That's how we can track what changes have been done and where htye have been backported.

Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my previous comment and #42998 (comment)

@oakrizan
Copy link
Contributor Author

oakrizan commented Mar 6, 2025

Please, backport #42998 instead of creating a new PR from scratch. It's not ideal, but I prefer we keep semantic with the backports, so if a PR already is merged with he content and needs to be backported back to other branches, let's use mergify. That's how we can track what changes have been done and where htye have been backported.

On main branch code is different, it has test collector plugin, while other branches don't

@v1v
Copy link
Member

v1v commented Mar 6, 2025

On main branch code is different, it has test collector plugin, while other branches don't

You can create the backport and then modify it afterwards. As I said, the more diligent we are with the processes, the easier the debugging will be when things fail in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify ci Team:Ingest-EngProd windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants