-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows 2025 for unit test steps for main branch #43054
base: main
Are you sure you want to change the base?
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
/test |
Please, backport #42998 instead of creating a new PR from scratch. It's not ideal, but I prefer we keep semantic with the backports, so if a PR already is merged with he content and needs to be backported back to other branches, let's use mergify. That's how we can track what changes have been done and where htye have been backported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my previous comment and #42998 (comment)
On main branch code is different, it has test collector plugin, while other branches don't |
You can create the backport and then modify it afterwards. As I said, the more diligent we are with the processes, the easier the debugging will be when things fail in the future. |
Proposed commit message
Based on Support Matrix Windows 2025 should be added for filebeat and metricbeat only. Updated Extended Windows unit test group with additional step per beats mentioned above.
Creating a separate PR for
main
branch and skipping for other branches, since pipeline definitions on8.x
,8.18
and9.0
has no test collector plugin enabled.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues
Logs
Buildkite filebeat build: https://buildkite.com/elastic/filebeat/builds/14290#0195681f-36ae-41a2-b537-8fdf66f31fba
Buiildkite metricbeat build: https://buildkite.com/elastic/beats-metricbeat/builds/14794#0195681f-3e35-474d-aa8c-ab51ce70a664