Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.16](backport #42420) [AWSs3 Input] Handle unexpectedEOF errors #43096

Open
wants to merge 1 commit into
base: 8.16
Choose a base branch
from
Open

[8.16](backport #42420) [AWSs3 Input] Handle unexpectedEOF errors #43096

wants to merge 1 commit into from
+7 −1

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 6, 2025

  • Enhancement

Proposed commit message

Please explain:

  • WHAT: Wraps UnexpectedEOF error in the result of readjson fucntion so the caller knows it's not a permanent failure
  • WHY: To be able to retry the processing of S3 json files in case of such errors. Until now

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Related issues

Screenshots

Logs

This is an automatic backport of pull request #42420 done by [Mergify](https://mergify.com).

@gizas @mergify
[AWSs3 Input] Handle unexpectedEOF errors (#42420)
9776705 
* return EOF error again as errS3DownloadFailed

Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>

---------

Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>
Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
(cherry picked from commit e6781f3)
@mergify mergify bot requested a review from a team as a code owner March 6, 2025 17:27
@mergify mergify bot added the backport label Mar 6, 2025
@mergify mergify bot assigned gizas Mar 6, 2025
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 6, 2025
@botelastic
Copy link

botelastic bot commented Mar 6, 2025

This pull request doesn't have a Team:<team> label.

@Kavindu-Dodan
Copy link
Contributor

@gizas won't approve as build was failing. Please have a look when you are back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gizas gizas

Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kavindu-Dodan @gizas