Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] fix monitoring test cases #5209

Closed
VihasMakwana opened this issue Jul 29, 2024 · 0 comments · Fixed by #5208
Closed

[Test] fix monitoring test cases #5209

VihasMakwana opened this issue Jul 29, 2024 · 0 comments · Fixed by #5208
Assignees
@VihasMakwana
Labels
bug Something isn't working Testing

Comments

@VihasMakwana
Copy link
Contributor

VihasMakwana commented Jul 29, 2024 •
edited
Loading

  1. TestMonitoringLivenessReloadable:

    elastic-agent/testing/integration/monitoring_probe_reload_test.go

    Lines 168 to 170 in 2676a3f

    status, err := runner.agentFixture.ExecStatus(ctx)
    require.NoError(runner.T(), err)

Current behaviour:
- TestMonitoringLivenessReloadable fails even if the status remains degraded momentarily.
Expected behaviour:
- TestMonitoringLivenessReloadable shouldn't fail due to temporary degraded state.
- The failure/success should depend on final statuses of all the components

Same goes for TestMonitoringPreserveTextConfig and TestLongRunningAgentForLeaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VihasMakwana VihasMakwana

Labels
bug Something isn't working Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tests][integration] fix monitoring test cases VihasMakwana/elastic-agent
1 participant
@VihasMakwana