Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.15](backport #5208) [tests][integration] fix monitoring test cases #5222

Merged
merged 1 commit into from
Jul 31, 2024
Merged

[8.15](backport #5208) [tests][integration] fix monitoring test cases #5222

merged 1 commit into from
Jul 31, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 30, 2024

  • Bug

What does this PR do?

  • With introduction of status reporter for metricbeat, integration test cases were failing
  • From diagnostics, it was observed that the status transitioned from HEALTHY to DEGRADED (momentarily) and again to HEALTHY.
  • Previous behaviour:
    • During the above transition, runner.agentFixture.ExecStatus(ctx) returned an error because of the momentarily DEGRADED state and it caused entire test to fail (even though it returned to a HEALTHY state, its just how go tests function).
  • This PR does the following:
    • Remove the check on error inside require.Eventually.
      • If all the components return to a healthy state, the test would pass eventually.
      • If it remains in a unhealthy state, the test would fail.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

closes #5209

This is an automatic backport of pull request #5208 done by [Mergify](https://mergify.com).

@VihasMakwana @mergify
[tests][integration] fix monitoring test cases (#5208)
ba8eca6 
* chore: fix monitoring test cases

* fix: update long running tests

* fix: change ExecStatus and return nil

* fix: update docstring, non-empty

* fix: reword

* fix: nit

* fix: empty line

* fix: join errors.

* temproray logs to examine CI

* Revert "temproray logs to examine CI"

remove logs as the test failure has been identified

This reverts commit dc392b3.

* fix: update condition

(cherry picked from commit 509b1cc)
@mergify mergify bot requested a review from a team as a code owner July 30, 2024 18:51
@mergify mergify bot added the backport label Jul 30, 2024
@mergify mergify bot requested review from blakerouse and faec and removed request for a team July 30, 2024 18:51
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@pierrehilbert pierrehilbert merged commit ca4a875 into 8.15 Jul 31, 2024
14 checks passed
@pierrehilbert pierrehilbert deleted the mergify/bp/8.15/pr-5208 branch July 31, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrehilbert pierrehilbert pierrehilbert approved these changes

@VihasMakwana VihasMakwana VihasMakwana approved these changes

@blakerouse blakerouse Awaiting requested review from blakerouse blakerouse is a code owner automatically assigned from elastic/elastic-agent-control-plane

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@VihasMakwana VihasMakwana

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierrehilbert @VihasMakwana