[8.13](backport #4172) Fix filemarker creation process, update error message on uninstall #4307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…4172) * move install file marker create, rename methods, change error message * change error message * change error message * remove calls to InstallMarkerExists * fix windows helper * fix windows, again * Revert "remove calls to InstallMarkerExists" This reverts commit 400bb0d. * change install file locaton, revert removal of filepath.Dir * fix wording * move IsUpgradeable, remove duplication * add tests * add mostly useless test * linter * tinkering with CI * skip supervisor test on windows * tinkering with the linter * remove experiment * refactor install to make adding tests easier * linter * add more tests... * still fixing tests * sonarQube * fix windows tests, fight sonarqube * tinker with file marker create * move install path * fix bad merge * still cleaning up merge * add tests * add tests, docs * fix tests * don't check mode bits * move command, fix permissions * SonarQube... * refactor dir setup to make Sonarqube happy * add changelog * Update changelog/fragments/1707951532-change-install-marker-creation.yaml Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co> --------- Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co> (cherry picked from commit 65e2c30)
mergify
bot
requested review from
michalpristas and
pchila
and removed request for
a team
|
66.7% Coverage on New Code
0.0% Duplication on New Code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #4172 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com