Ensure integration test setup has a timeout. #4478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The top level context for integration tests comes from mage, which doesn't set a default timeout unless you give it one on the command line, which we don't do. Detect when the timeout wasn't set, and force a reasonable default.
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
|
This pull request does not have a backport label. Could you fix it @cmacknz? 🙏
NOTE: |
cmacknz
commented
Mar 25, 2024
| // goIntegTestTimeout is the timeout passed to each instance of 'go test' used in integration tests. | ||
| goIntegTestTimeout = 2 * time.Hour | ||
| // goProvisionAndTestTimeout is the timeout used for both provisioning and running tests. | ||
| goProvisionAndTestTimeout = goIntegTestTimeout + 30*time.Minute |
There was a problem hiding this comment.
Scientifically chosen by looking at the total time of the integration test stage for recent builds. It frequently goes over 2h so I couldn't also use 2h for this.
- 2h9m https://buildkite.com/elastic/elastic-agent/builds/7928#018e6376-e786-4ba4-b2eb-fc521ed64ae7
- 2h7m https://buildkite.com/elastic/elastic-agent/builds/7938#018e6a11-a2db-466f-8b8f-548febe75ddb
- 1h53m https://buildkite.com/elastic/elastic-agent/builds/7916
We could probably shorten this but I want to avoid false positives.
|
rdner
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The top level context for integration tests comes from mage, which doesn't set a default timeout unless you give it one on the command line, which we don't do.
Detect when the timeout wasn't set, and force a reasonable default. Hopefully this prevents the tests from running indefinitely when the failure is in the setup and provisioning stage.