Increase removal timeout when uninstall #4921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On particularly slow machines 30 seconds might be still not enough to release the agent binary, so we're able to remove it on uninstall. This change doubles the timeout to 60 seconds.
rdner
added
bug
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
This pull request does not have a backport label. Could you fix it @rdner? 🙏
NOTE: |
rdner
added
backport-v8.14.0
|
pchila
approved these changes
Jun 13, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
On particularly slow machines 30 seconds might be still not enough to release the agent binary, so we're able to remove it on uninstall. This change doubles the timeout to 60 seconds. (cherry picked from commit 1f3ddcd)
rdner
added a commit
that referenced
this pull request
Jun 14, 2024
On particularly slow machines 30 seconds might be still not enough to release the agent binary, so we're able to remove it on uninstall. This change doubles the timeout to 60 seconds. (cherry picked from commit 1f3ddcd) Co-authored-by: Denis <denis.rechkunov@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On particularly slow machines 30 seconds might be still not enough to release the agent binary, so we're able to remove it on uninstall. This change doubles the timeout to 60 seconds.