Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump gowin32 for arm64 support #5362

Merged
merged 5 commits into from
Sep 3, 2024

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Aug 27, 2024

What does this PR do?

bump gowin32 for arm64 support

See winlabs/gowin32#87

Why is it important?

gowin32 does not support windows arm causing elastic-agent to fail to compile on windows/arm64

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

GOOS=windows GOARCH=arm64 go build

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@kruskall kruskall added the enhancement New feature or request label Aug 27, 2024
@kruskall kruskall requested a review from a team as a code owner August 27, 2024 01:04
Copy link
Contributor

mergify bot commented Aug 27, 2024

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Aug 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@pierrehilbert
Copy link
Contributor

@kruskall Thanks for contributing (as always).
Do you think we can have the change upstream and therefore use this fork only as a short term solution?

@kruskall
Copy link
Member Author

Do you think we can have the change upstream and therefore use this fork only as a short term solution?

I'd love to but the upstream project seems to be abandoned https://github.com/winlabs/gowin32 so I went with a fork :(

@pierrehilbert
Copy link
Contributor

Maybe we can try in parallel to open a PR to see if people are not actively contributing to it but are still okay to review the work?

Copy link
Contributor

mergify bot commented Aug 27, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feat/windows-arm upstream/feat/windows-arm
git merge upstream/main
git push upstream feat/windows-arm

@kruskall
Copy link
Member Author

kruskall commented Aug 27, 2024

Hey 👋

winlabs/gowin32#87 should be the bare minimum to support elastic agent on windows/arm64.

It's not a great solution (duplicate code and it's only updating functions that we need) but the library has a lot of tech debts.

@kruskall kruskall changed the title feat: use custom gowin32 library for windows arm support feat: bump gowin32 for arm64 support Aug 28, 2024
@kruskall
Copy link
Member Author

dgolub merged commit 3c8ae99 into winlabs:master

@kruskall
Copy link
Member Author

@pierrehilbert thank you for pushing back on this and suggesting to open a PR upstream! 🙇

@pierrehilbert
Copy link
Contributor

This is a great news, I'm glad to see this outcome!
Thanks for considering my idea and to make it succeed haha

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@kruskall kruskall enabled auto-merge (squash) September 3, 2024 09:08
@kruskall kruskall merged commit 1e57055 into elastic:main Sep 3, 2024
13 checks passed
@kruskall kruskall deleted the feat/windows-arm branch September 3, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip enhancement New feature or request skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants