-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump gowin32 for arm64 support #5362
Conversation
This pull request does not have a backport label. Could you fix it @kruskall? 🙏
NOTE: |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
@kruskall Thanks for contributing (as always). |
I'd love to but the upstream project seems to be abandoned https://github.com/winlabs/gowin32 so I went with a fork :( |
Maybe we can try in parallel to open a PR to see if people are not actively contributing to it but are still okay to review the work? |
This pull request is now in conflicts. Could you fix it? 🙏
|
Hey 👋 winlabs/gowin32#87 should be the bare minimum to support elastic agent on windows/arm64. It's not a great solution (duplicate code and it's only updating functions that we need) but the library has a lot of tech debts. |
27aafe1
to
caabdda
Compare
|
@pierrehilbert thank you for pushing back on this and suggesting to open a PR upstream! 🙇 |
This is a great news, I'm glad to see this outcome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
|
What does this PR do?
bump gowin32 for arm64 support
See winlabs/gowin32#87
Why is it important?
gowin32 does not support windows arm causing elastic-agent to fail to compile on windows/arm64
Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
How to test this PR locally
GOOS=windows GOARCH=arm64 go build
Related issues
Questions to ask yourself