[8.15](backport #5329) Fixes issue where context cancelling could result in an invalid error being reported #5482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
… being reported (#5329) * Fix issue. * Update internal/pkg/agent/application/gateway/fleet/fleet_gateway.go Co-authored-by: Paolo Chilà <paolo.chila@elastic.co> * Remove check for failed as it no-longer gets marked failed. --------- Co-authored-by: Paolo Chilà <paolo.chila@elastic.co> Co-authored-by: Pierre HILBERT <pierre.hilbert@elastic.co> Co-authored-by: Julien Lind <julien.lind@elastic.co> Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> (cherry picked from commit 96e02e0)
mergify
bot
requested review from
blakerouse and
swiatekm
and removed request for
a team
blakerouse
approved these changes
Sep 9, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When the Fleet checkin look context is cancelled it no longer will return an error in rare cases.
Why is it important?
Possible to cause an error to be reported when it was just context cancellation.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added an entry in./changelog/fragmentsusing the changelog toolDisruptive User Impact
None
Related issues
This is an automatic backport of pull request #5329 done by [Mergify](https://mergify.com).