-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.x](backport #5556) Add pprofextension from the OTel-contrib #5577
Conversation
Cherry-pick of aa56bc9 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are a couple git conflicts to be fixed.
This pull request has not been merged yet. Could you please review and merge it @alexsapran? 🙏 |
afad4a7
to
8743cc9
Compare
Cherry-picked the commit again, isolating the original change from all the version bumps that got in the automatic backport. If we want to bump otel dependencies we should either backport the original PR or use the automation also on 8.x @mauri870 could you have another look ? |
* Add pprofextension from the OTel-contrilib This commit adds the pprofextension to the OTel collector. Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
8743cc9
to
74269be
Compare
updated the PR and kept only the original changes without the other version bumps
/test |
Failures in TestAPMConfig may be caused by #5615 (there are HTTP 502/503 errors coming from the APM agent in the logs), need to retest once that fix has been merged |
This pull request has not been merged yet. Could you please review and merge it @alexsapran? 🙏 |
/test |
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request has not been merged yet. Could you please review and merge it @alexsapran? 🙏 |
Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
/test |
|
What does this PR do?
This comit adds the pprofextension to the OTel collector.
Why is it important?
As part of running benchmarks for Elastic-Agent we need to be able to take diagnostic profiles and as we onboard the OTel collector to the framework we need to enable Pprof for the OTel collector.
Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
How to test this PR locally
Once you have a packaged version of Elastic-Agent then you can start it with the following OTel config
Related issues
Questions to ask yourself
This is an automatic backport of pull request #5556 done by [Mergify](https://mergify.com).