feat: drop init.d support and go-daemon binaries

[kruskall]

What does this PR do?

remove init.d scripts
drop go-daemon dep and daemon binaries
cleanup mage tasks

Why is it important?

Similar to elastic/beats#41845

init.d should not be needed on distros we support
According to go-daemon readme: "Go daemon is not needed on systems with systemd."

See https://www.elastic.co/support/matrix#matrix_os

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in ./changelog/fragments using the changelog tool
• I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

• How are we going to support this in production?
• How are we going to measure its adoption?
• How are we going to debug this?
• What are the metrics I should take care of?
• ...

[mergify]

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

[mergify]

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

[elasticmachine]

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

[elastic-sonarqube]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feat/drop-go-daemon upstream/feat/drop-go-daemon
git merge upstream/main
git push upstream feat/drop-go-daemon

[kaanyalti]

Code changes look good to me, but I don't have enough context here, if someone else can look at it as well it would be better.

[cmacknz]

This is fine as long as the DEB and RPM packages still run as services. That there is no replacement systemd unit file added here makes me think we may have broken something. I see the DEB tests are failing now, so that is one potential reason.

We create out existing systemd service in Go code right now so there isn't an easy way to extract it without refactoring that.

elastic-agent/internal/pkg/agent/install/svc.go

Line 84 in 54932dc

if runtime.GOOS == "linux" {

[blakerouse]

I think this change is possible because it is true that on DEB/RPM that we do not support any OS that uses sysvinit. But there is clearly an issue with the upgrade path for the deb packages.

Interested to determine what you find on why that is not working with these changes. I am going to mark this as "Request changes" only, because I was to review it again before its merged with that fixed.

[cmacknz]

There is an actual bug related to us continuing to include init.d files now #6704

[elasticmachine]

💔 Build Failed

• Buildkite Build
• Commit: 7c5eb7e

Failed CI Steps

• Unit tests - Windows 2016
• x86_64:sudo: deb
• x86_64:sudo: deb
• x86_64:sudo:rpm
• x86_64:sudo:rpm

History

• 💔 Build #17705 failed 24571b5

cc @kruskall

[elastic-sonarqube]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube