Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mergify: update rules #6706

Merged
merged 1 commit into from
Feb 7, 2025
Merged

mergify: update rules #6706

merged 1 commit into from
Feb 7, 2025

Conversation

v1v
Copy link
Member

@v1v v1v commented Feb 4, 2025

What does this PR do?

Update mergify rules to use the Buildkite checks and remove the automation labels and update some other bits and pieces

Why is it important?

This should help with:

  • auto-merge some PRs related to the FF
  • delete branches for closed or merged PRs.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@v1v v1v self-assigned this Feb 4, 2025
@v1v v1v requested a review from a team as a code owner February 4, 2025 18:27
@v1v v1v requested review from blakerouse and kaanyalti February 4, 2025 18:27
@@ -61,16 +61,14 @@ pull_request_rules:
- merged
- closed
- and:
- label=automation
- head~=^update-go-version
- head~=^updatecli.*
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #6700

Comment on lines +87 to +95
- name: delete upstream branch for mergify backports
conditions:
- or:
- merged
- closed
- and:
- head~=^mergify/bp/.*
actions:
delete_head_branch:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to delete any branches coming from PRs always after they are merged or closed

- name: delete upstream branch with changes on ^.mergify.yml that has been merged or closed
conditions:
- or:
- merged
- closed
- and:
- label=automation
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this label is not something used anymore, apparently -> #6645

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@v1v v1v enabled auto-merge (squash) February 6, 2025 18:33
@v1v v1v merged commit de2b544 into elastic:main Feb 7, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants