Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http response status checks to TestSetLogLevelFleetManaged #7049

Conversation

pchila
Copy link
Member

@pchila pchila commented Feb 26, 2025

What does this PR do?

This PR adds some checks on fleet server http responses in integration test TestSetLogLevelFleetManaged which is known to be flaky.
This change should help with the investigation.

Why is it important?

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Disruptive User Impact

No user impact since this is a change in an elastic-agent integration test

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pchila pchila added bug Something isn't working flaky-test Unstable or unreliable test cases. labels Feb 26, 2025
@pchila pchila self-assigned this Feb 26, 2025
Copy link
Contributor

mergify bot commented Feb 26, 2025

This pull request does not have a backport label. Could you fix it @pchila? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@pchila pchila force-pushed the add-fleet-response-checks-to-TestSetLogLevelFleetManaged branch from 5aa4d03 to 5fd0232 Compare February 26, 2025 17:37
@pchila pchila marked this pull request as ready for review February 26, 2025 17:39
@pchila pchila requested a review from a team as a code owner February 26, 2025 17:39
@pchila pchila requested a review from swiatekm February 26, 2025 17:39
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 27, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @pchila

Copy link

@pkoutsovasilis
Copy link
Contributor

pkoutsovasilis commented Feb 27, 2025

created an issue to capture a new flaky test here. Every other failure is already reported thus retrying

@pchila pchila merged commit 6269c7e into elastic:main Feb 28, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flaky-test Unstable or unreliable test cases. skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants