-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recreate kind cluster after each K8s test #7111
Open
swiatekm
wants to merge
1
commit into
main
Choose a base branch
from
ci/kind-cluster-per-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request does not have a backport label. Could you fix it @swiatekm? 🙏
|
11bf290
to
4cdf1ec
Compare
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
This is a temporary measure to improve K8s test reliability before we can run them in parallel. We run these tests sequentially right now, and each kind cluster is only used once, but is only cleaned up after all tests finish running. Creating and deleting kind clusters is fast relative to test run time, so this shouldn't impact total run time significantly.
4cdf1ec
to
ec65a9f
Compare
|
💚 Build Succeeded
History
cc @swiatekm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automation
backport-active-all
Automated backport with mergify to all the active branches
ci
Cleanup
skip-changelog
Team:Elastic-Agent-Control-Plane
Label for the Agent Control Plane team
Team:Ingest-EngProd
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creates a new kind cluster for each K8s test.
Why is it important?
This is a temporary measure to improve K8s test reliability before we can run them in parallel. We run these tests sequentially right now, and each kind cluster is only used once, but is only cleaned up after all tests finish running. Creating and deleting kind clusters is fast relative to test run time, so this shouldn't impact total run time significantly.
Kubernetes tests took 2h 31m on this branch: https://buildkite.com/elastic/elastic-agent/builds/17875#01955b43-3ce0-4b43-814b-e433929b6ff2.
On main they recently took 2h 30m: https://buildkite.com/elastic/elastic-agent-extended-testing/builds/7791#01954e7c-ac7c-43fc-9987-1431e2c3b2ad
So there's little difference in runtime, and potential to fix some flakiness in the short-term.
Checklist
How to test this PR locally
Related issues