-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fips attribute to agent metadata sent to fleet #7112
Open
michel-laterman
wants to merge
6
commits into
elastic:main
Choose a base branch
from
michel-laterman:agent-metadata-fips
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
5a6d17e
to
e66f00d
Compare
@michel-laterman seems like unit tests need to be updated to add the fips field in the expected json. |
simitt
approved these changes
Mar 4, 2025
⏳ Build in-progress, with failures
Failed CI Steps
History
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-8.x
Automated backport to the 8.x branch with mergify
backport-8.18
Automated backport to the 8.18 branch
backport-9.0
Automated backport to the 9.0 branch
enhancement
New feature or request
Team:Elastic-Agent-Control-Plane
Label for the Agent Control Plane team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add elastic.agent.fips (bool) attribute to local_metadata sent with enroll and checkin requests.
The value of this attribute indicates if the agent is a FIPS compliant distribution.
Why is it important?
elastic-agent needs to be able to signal to fleet-server if it is running a FIPS distributable.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration files./changelog/fragments
using the changelog toolI have added an integration test or an E2E testDisruptive User Impact
N/A