Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update Buildkite configuration for tags in main pipeline #4469

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Feb 13, 2025

What is the problem this PR solves?

Restore buildkite settings to trigger builds on tags.
This are required to trigger the step:

- label: ":jenkins: Release - Package Registry Distribution"
key: "release-package-registry"
trigger: "package-registry-release-package-registry-distribution"
async: true
build:
branch: "main"
meta_data:
DOCKER_TAG: "${BUILDKITE_TAG}"
if: "build.env('BUILDKITE_TAG') != ''"

How does this PR solve the problem?

// Explain HOW you solved the problem in your code. It is possible that during PR reviews this changes and then this section should be updated.

How to test this PR locally

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

@mrodm mrodm requested a review from v1v February 13, 2025 10:01
@mrodm mrodm self-assigned this Feb 13, 2025
@mrodm mrodm requested a review from a team as a code owner February 13, 2025 10:01
@mrodm mrodm added the backport-skip Skip notification from the automated backport with mergify label Feb 13, 2025
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mario, for explaining what's the purpose of those changes.

@v1v v1v enabled auto-merge (squash) February 13, 2025 11:24
Copy link

@v1v v1v disabled auto-merge February 13, 2025 17:26
@v1v v1v enabled auto-merge (squash) February 13, 2025 17:26
@mrodm mrodm added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Feb 14, 2025
@v1v v1v merged commit fbd06e0 into elastic:main Feb 14, 2025
9 checks passed
@mrodm mrodm deleted the restore_builds_on_tags_buildkite branch February 14, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants