Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use golang-crossbuild native to ARM64 #4536

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

use golang-crossbuild native to ARM64 #4536

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2885b8
test: golang-crossbuild native to ARM64
v1v Mar 3, 2025
6efc900
test: golang-crossbuild
v1v Mar 3, 2025
cedc69e
Revert "test: golang-crossbuild"
v1v Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ BUILDMODE_darwin_amd64=-buildmode=pie
BUILDMODE_darwin_arm64=-buildmode=pie

CROSSBUILD_SUFFIX=main-debian11
CROSSBUILD_ARM_SUFFIX=base-arm-debian9
STANDALONE_DOCKERFILE=Dockerfile
BUILDER_IMAGE=fleet-server-builder:${GO_VERSION}

Expand Down Expand Up @@ -312,7 +313,7 @@ endif

build-releaser: ## - Build a Docker image to run make package including all build tools
ifeq ($(shell uname -p),arm)
$(eval SUFFIX := arm)
$(eval SUFFIX := ${CROSSBUILD_ARM_SUFFIX})
Comment on lines -315 to +316
Copy link
Member Author

@v1v v1v Mar 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arm suffix points to debian9, that's how it works in the golang-crossbuild, see elastic/golang-crossbuild#446 that explains that currently the default debian image is 9.

else
$(eval SUFFIX := ${CROSSBUILD_SUFFIX})
endif
Expand Down