[1.23] fix(go/base): set GOTOOLCHAIN=local and skip building arm using the base Dockerfile #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable the automatic downloads of the Go toolchain. For the goal of reproducible builds using golang-crossbuild, we want all of the binaries used to produce our artifacts to be self-contained in the image. Adding GOTOOLCHAIN=local disable downloads of newer toolchains. This changes the entrypoint of the images to document that GOTOOLCHAIN is set during builds. And it sets GOTOOLCHAIN=local in the Dockerfile so that when building entrypoint.go it uses the toolchain that was previously installed. The two Dockerfiles (base and base-arm) had different 'go build' commands. This unifies them to both have CGO_ENABLED=0 and to explicitly set GOARCH to avoid accidentally producing a binary for the wrong target architecture (which we've seen happen for unknown reasons). https://go.dev/doc/toolchain
This reverts commit f06635b.
💚 Build Succeeded
|
v1v
added a commit
to v1v/beats
that referenced
this pull request
Feb 28, 2025
💚 Build Succeeded
|
💔 Build Failed
Failed CI Steps
History |
v1v
changed the title
6 tasks
v1v
added a commit
to elastic/fleet-server
that referenced
this pull request
Mar 3, 2025
8 tasks
pazone
approved these changes
Mar 3, 2025
This was referenced Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #524 and #523
Waiting for https://buildkite.com/elastic/auditbeat/builds?branch=v1v%3Atest%2F42705
and wait for those PRs that are good to be merged, then we can merge this as long as elastic/beats#42960 passes