[O11y][MSSQL] Add optional mssql.query field to performance data stream for debugging purposes
#12212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harnish-elastic
added
Team:Obs-InfraObs
harnish-elastic
changed the title
packages/microsoft_sqlserver/data_stream/performance/manifest.yml
Outdated
Show resolved
Hide resolved
| @@ -81,3 +81,6 @@ | |||
| - name: memory_grants_pending | |||
| type: long | |||
| description: This is generated from the default pattern given for Dynamic Counter Name variable. This counter tells us how many processes are waiting for the memory to be assigned to them so they can get started. | |||
| - name: query | |||
| type: keyword | |||
| description: Executed queries by this package. | |||
There was a problem hiding this comment.
Lets wait till the beats code change, This can be an array.
There was a problem hiding this comment.
array won't be supported.
Error: building package failed: invalid content found in built zip package: found 1 validation error:
- file "/github_repo/harnish_repo/integrations/build/packages/microsoft_sqlserver-2.9.5.zip/data_stream/performance/fields/fields.yml" is invalid: field 0.fields.1.type: 0.fields.1.type must be one of the following: "aggregate_metric_double", "alias", "histogram", "constant_keyword", "text", "match_only_text", "keyword", "long", "integer", "short", "byte", "double", "float", "half_float", "scaled_float", "date", "date_nanos", "boolean", "binary", "integer_range", "float_range", "long_range", "double_range", "date_range", "ip_range", "group", "geo_point", "object", "ip", "nested", "flattened", "wildcard", "version", "unsigned_long"
6 tasks
6 tasks
harnish-elastic
changed the title
performance data stream for debugging purposes
🚀 Benchmarks reportTo see the full report comment with |
harnish-elastic
changed the title
performance data stream for debugging purposesperformance data stream for debugging purposes
harnish-elastic
added
enhancement
shmsr
reviewed
Jan 16, 2025
Comment on lines
21
to
28
| - name: preserve_sql_queries | ||
| required: true | ||
| show_user: false | ||
| title: Preserve SQL queries (debug) | ||
| description: Preserve the SQL queries used. Enable for debugging purposes only. This feature becomes available in Kibana version 8.18 onwards. | ||
| type: bool | ||
| multi: false | ||
| default: false |
There was a problem hiding this comment.
Suggested change
| - name: preserve_sql_queries | |
| required: true | |
| show_user: false | |
| title: Preserve SQL queries (debug) | |
| description: Preserve the SQL queries used. Enable for debugging purposes only. This feature becomes available in Kibana version 8.18 onwards. | |
| type: bool | |
| multi: false | |
| default: false | |
| - name: preserve_sql_queries | |
| required: true | |
| show_user: false | |
| title: Preserve SQL Queries | |
| description: Preserves SQL queries for debugging purposes. This feature is available in Elastic stack version 8.18 and later. | |
| type: bool | |
| multi: false | |
| default: false |
Comment on lines
52
to
55
| tags: | ||
| {{#if preserve_sql_queries}} | ||
| - preserve_sql_queries | ||
| {{/if}} |
There was a problem hiding this comment.
https://github.com/elastic/integrations/pull/12097/files
^^
Here we are not accepting tags from users as of now. But see this PR where because of indentation we faced issue when user input was also there.
There was a problem hiding this comment.
Updated, thanks!
| @@ -81,3 +81,6 @@ | |||
| - name: memory_grants_pending | |||
| type: long | |||
| description: This is generated from the default pattern given for Dynamic Counter Name variable. This counter tells us how many processes are waiting for the memory to be assigned to them so they can get started. | |||
| - name: query | |||
| type: keyword | |||
| description: Executed queries by this package. | |||
There was a problem hiding this comment.
Suggested change
| description: Executed queries by this package. | |
| description: The SQL queries executed. |
Merged
5 tasks
💚 Build Succeeded
History
|
|
shmsr
approved these changes
Jan 17, 2025
shmsr
approved these changes
Jan 17, 2025
|
Package microsoft_sqlserver - 2.10.0 containing this change is available at https://epr.elastic.co/package/microsoft_sqlserver/2.10.0/ |
harnish-elastic
added a commit
to harnish-elastic/integrations
that referenced
this pull request
Feb 4, 2025
…ream for debugging purposes (elastic#12212) * Remove unnecessary processor in performance data stream * add changelog entry * added debug flag that can preserve mssql.query field when enabled * Update packages/microsoft_sqlserver/data_stream/performance/manifest.yml Co-authored-by: Lalit Satapathy <69236064+lalit-satapathy@users.noreply.github.com> * update tag name * minor change in pipeline and system tests * minor change in tag description * address review comments --------- Co-authored-by: Lalit Satapathy <69236064+lalit-satapathy@users.noreply.github.com>
harnish-elastic
added a commit
to harnish-elastic/integrations
that referenced
this pull request
Feb 5, 2025
…ream for debugging purposes (elastic#12212) * Remove unnecessary processor in performance data stream * add changelog entry * added debug flag that can preserve mssql.query field when enabled * Update packages/microsoft_sqlserver/data_stream/performance/manifest.yml Co-authored-by: Lalit Satapathy <69236064+lalit-satapathy@users.noreply.github.com> * update tag name * minor change in pipeline and system tests * minor change in tag description * address review comments --------- Co-authored-by: Lalit Satapathy <69236064+lalit-satapathy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
perfromancedata stream uses the merge_results: true parameter. From this parameter, I observed that all the sql_queries results are being merged in single event and we are not receiving thesql.queryfield in the response. Referpreserve_sql_queriesflag that can be used as preserve sql.query field, if it's enabled.Checklist
changelog.ymlfile.Related issues
Screenshot