Skip to content

[fortinet_fortigate] Set bad URL to url.original #13767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 2, 2025

Conversation

dwhyrock
Copy link
Contributor

@dwhyrock dwhyrock commented May 2, 2025

Proposed commit message

Instead of causing an error when an invalid URI is processed with the uri_parts processor, this instead sets the value to url.original.

This adds several example logs to test against.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@dwhyrock dwhyrock added Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels May 2, 2025
@dwhyrock dwhyrock requested a review from a team as a code owner May 2, 2025 18:10
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwhyrock dwhyrock merged commit 2086492 into elastic:main May 2, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Package fortinet_fortigate - 1.32.1 containing this change is available at https://epr.elastic.co/package/fortinet_fortigate/1.32.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants