[Fleet] Fix isPackageVersionOrLaterInstalled to check for installed package

[nchaulet]

Description

Resolve elastic/elastic-agent#4102

Fix isPackageVersionOrLaterInstalled to check for installed package and retry when package is in installing status

Work in progress

Test

The changes are unit tested, I do not think it will be easy/usefull to add an api test here as that scenario happen during some race condition.

You can manually test the race condition by introducing a delay in the intallation
How to reproduce the bug I introduce an artificial delay in the package install process

--- a/x-pack/plugins/fleet/server/services/epm/packages/_install_package.ts
+++ b/x-pack/plugins/fleet/server/services/epm/packages/_install_package.ts
@@ -150,6 +150,7 @@ export async function _installPackage({
         spaceId,
         verificationResult,
       });
+      await new Promise((resolve) => setTimeout(resolve, 30 * 1000));
     }
     logger.debug(`Package install - Installing Kibana assets`);
     const kibanaAssetPromise = withPackageSpan('Install Kibana assets', () =>

And try to create two agent policy concurently

Todo

• unit test for isPackageVersionOrLaterInstalled
• Should we wrote a release not for that one?

[apmmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[nchaulet]

/ci

[nchaulet]

I removed the installType here as it seems not used by that function consumers, and it seems that function should not return it as it's not creating an install but checking if one exist

[elasticmachine]

Pinging @elastic/fleet (Team:Fleet)

[nchaulet]

@elasticmachine merge upstream

[kpollich]

I'm good with merging this as-is. Happy with the testing approach here. Thanks for tracking this down.

[kpollich]

This can probably get a release note fix label and that should suffice for release notes.

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 81f4125

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

[juliaElastic]

Should this be backported to 8.12?

[nchaulet]

Should this be backported to 8.12?

it touch a part of the code that is a little tricky, and the bug it's fixing is only happening in some scenario of race condition not sure it's worth taking the risk to backport it.

[kpollich]

+1 let's not backport this to be safe.