Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Fix concurent package policies create #178993

Merged

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Mar 19, 2024

Description

Resolve elastic/elastic-agent#4102

Fix concurrent package policies create, when two custom log package policies are create at the same time it happen to have a conflict where we try to retrieve the package from ES before it's installed this should fix it.

Todo

  • add some test
  • check for side effects

@nchaulet nchaulet self-assigned this Mar 19, 2024
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@nchaulet
Copy link
Member Author

/ci

@nchaulet nchaulet marked this pull request as ready for review March 19, 2024 18:24
@nchaulet nchaulet requested a review from a team as a code owner March 19, 2024 18:24
@nchaulet
Copy link
Member Author

/ci

@nchaulet nchaulet added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team labels Mar 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliaElastic
Copy link
Contributor

Should we backport this to 8.13 branch?

@nchaulet
Copy link
Member Author

nchaulet commented Mar 20, 2024

Should we backport this to 8.13 branch?

As we are at the end of the 8.13 cycle it may be safer to not backport it, this touch a very critical part of the code and while I tested it carefully and we have some automated tests, I feel like releasing it for 8.14 will be safer

@nchaulet nchaulet merged commit 495d7b5 into elastic:main Mar 20, 2024
25 checks passed
@kibanamachine kibanamachine added v8.14.0 backport:skip This commit does not require backporting labels Mar 20, 2024
@nchaulet nchaulet deleted the fix-concurrent-package-policies-create branch March 20, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.14.0
Projects
None yet
6 participants