Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Remove bulk create rules API calls from rule export tests #198953

Merged

Conversation

banderror
Copy link
Contributor

@banderror banderror commented Nov 5, 2024

Follow-up to: #197422 (comment)

Summary

This PR manually "backports" some of the changes from #197422 directly to the 8.x branch. Specifically, it removes API calls to the rules _bulk_create API endpoint from the tests for exporting rules. This API endpoint has been disabled in main (=> Serverless and Kibana 9.0) and should not be used in code. This PR aims to reduce the chances of introducing conflicts with any further changes to rule export tests.

@banderror banderror added test Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team labels Nov 5, 2024
@banderror banderror self-assigned this Nov 5, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@banderror banderror force-pushed the remove-bulk-create-rules-api-calls branch from b3a594b to 6f8ceb1 Compare November 6, 2024 13:14
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @banderror

@banderror banderror merged commit b4fcf8c into elastic:8.x Nov 6, 2024
20 checks passed
@banderror banderror deleted the remove-bulk-create-rules-api-calls branch November 6, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Rule Management Security Solution Detection Rule Management area release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test v8.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants