Skip to content

Commit

Permalink
Fix Docker image to specific Golang version
Browse files Browse the repository at this point in the history
So far the `:latest` image was used for Golang. To be used in production I prefer to tied it to a very specific version so we know what is run and what we test is identical.

A file `.go_version` was introduced which long term should serve as the single point of through for the go version, also for CI. At the moment it is only there for documentation purpose.

Note: As part of this change I also looked into using the alpine Golang image but it does not have Git included, which makes working with the Golang mod dependency trickier.
  • Loading branch information
ruflin committed Sep 12, 2019
1 parent 2176d2f commit 4baed54
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions .go_version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
1.13.0
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:latest
FROM golang:${GO_VERSION:-1.13.0}

RUN \
apt-get update \
Expand Down

0 comments on commit 4baed54

Please sign in to comment.