Prepare elastic/logs track for the new logs index mode. #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By replacing index_sorting and synthetic_source_mode parameters by index_mode parameter.
martijnvg
force-pushed
the
prepare_elastic-logs_for_logs_index_mode
branch
from
ae727d2 to
7df7429
Compare
|
Note that I successfully ran esbench with elastic/logs track using the changes in this PR. |
| "index": { | ||
| {% if index_sorting == "hostname" %} | ||
| "mode": {{ index_mode | tojson }}, |
There was a problem hiding this comment.
I am not sure if there is any missing value for the hostname...just in case maybe we could add also index.sort.missing?
|
LGTM...I just left a minor comment. |
salvatore-campagna
approved these changes
Jun 4, 2024
gareth-ellis
pushed a commit
that referenced
this pull request
Jun 5, 2024
By replacing index_sorting and synthetic_source_mode parameters by index_mode parameter. (cherry picked from commit a71ef11)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By replacing index_sorting and synthetic_source_mode parameters (added via #522) by the index_mode parameter.
Closes elastic/elasticsearch#107222