Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto follow pattern challenge #734

Conversation

martijnvg
Copy link
Member

@martijnvg martijnvg commented Jan 29, 2025

Add a new challenge that uses auto follow pattern to auto follow data streams with logs-* pattern into the local cluster. This allows to benchmark CCR in a semi realistic way while the data set gets indexed, without running multiple clusters.

"iterations": 1
},
{
"name": "shard-recovery-small_2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: here you use "_2" (underscore) while below you use "-2" (dash)

@@ -62,10 +62,13 @@

{% set p_recovery_target = (recovery_target | default('logs-k8-application.log-default') ) %}
{% set p_recovery_from_seq_no = (recovery_seq_no | default(0) ) %}
{% set p_recovery_from_seq_no_2 = (recovery_seq_no_2 | default(1000000) ) %}
{% set p_recovery_from_seq_no_3 = (recovery_seq_no_3 | default(2000000) ) %}
{% set p_recovery_from_seq_no_4 = (recovery_seq_no_4 | default(3000000) ) %}
Copy link
Contributor

@salvatore-campagna salvatore-campagna Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this is way too high. AFAIK there are only 1_230_000 docs in k8s logs.

@salvatore-campagna
Copy link
Contributor

LGTM apart a nit.

@salvatore-campagna salvatore-campagna self-requested a review January 29, 2025 15:52
Instead of invoking shard change api 30 times with same parameters. Do 4 seperate invocations with different from_seqno and no warmup.
@martijnvg martijnvg force-pushed the elastic_logs_synthetic_source_recovery_more_improvement branch from 89a2a80 to 1775eef Compare January 30, 2025 08:16
@salvatore-campagna
Copy link
Contributor

LGTM 2.

@martijnvg martijnvg changed the title Improve elastic/logs synthetic-source-recovery challenge. Add auto follow pattern challenge Feb 3, 2025
{% import "rally.helpers" as rally %}
{% set p_follow_index_pattern = "copy-{{leader_index}}" %}
{
"name": "auto-follow-pattern",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can use a better name for the challenge...something that reminds what this does? Something like "ccr-shard-recovery". I guess this track is not only useful for synthetic source... but probably it would provide useful info in Serverless too where we probably retrieve data from S3?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can use a better name for the challenge...something that reminds what this does?

+1 - I will add ccr replication to the name and add a description.

. I guess this track is not only useful for synthetic source... but probably it would provide useful info in Serverless too where we probably retrieve data from S3?

IIRC CCR currently only works in stateful. To keep the follower indices up to date it relies on operation based replication, which doesn't exist in serverless.

@salvatore-campagna
Copy link
Contributor

LGTM

@martijnvg martijnvg merged commit e2d7794 into elastic:master Feb 4, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants