Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github-action): use hardcoded package name #887

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

v1v
Copy link
Member

@v1v v1v commented Jan 12, 2024

We have agreed to use this approach:

Given the name of the package never changes and I dont expect it to change anytime in the future. We can replace the value of the .name with @elastic/synthetics since the release is specific to the synthetics package.

This will help with solving the issue defined in here

We have agreed to use this approach:

> Given the name of the package never changes and I dont expect it to change anytime in the future. We can replace the value of the .name with @elastic/synthetics since the release is specific to the synthetics package.

This will help with solving the issue defined in here
@v1v v1v requested review from vigneshshanmugam and a team January 12, 2024 12:23
@v1v v1v self-assigned this Jan 12, 2024
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @v1v

@vigneshshanmugam vigneshshanmugam merged commit aa2102c into main Jan 12, 2024
7 checks passed
@vigneshshanmugam vigneshshanmugam deleted the v1v-patch-1 branch January 12, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants