Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the support for PHP 8.4 #14

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Add the support for PHP 8.4 #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
004e06d
php.yml: run tests under PHP 8.4 as well
macbre Jan 6, 2025
6953f31
composer: require PHPUnit 11.5 or 10.3
macbre Jan 13, 2025
6eb5068
XMLParser: resolve PHP 8.4 deprecations
macbre Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ jobs:
php-versions:
- '8.1'
- '8.2'
- '8.3' # nightly
- '8.3'
- '8.4'

steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"php": "^8.1"
},
"require-dev": {
"phpunit/phpunit": "^10.3",
"phpunit/phpunit": "^10.3 || ^11.5",
"friendsofphp/php-cs-fixer": "^3.22"
},
"scripts": {
Expand Down
8 changes: 4 additions & 4 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions src/XMLParser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,8 @@ public function setUp(): void
* Once the iterator goes through them all, the self::next() method
* will read and parse the next portion of the input XML stream.
*/
xml_set_object($this->parser, $this);
xml_set_element_handler($this->parser, 'startXML', 'endXML');
xml_set_character_data_handler($this->parser, 'charXML');
xml_set_element_handler($this->parser, [$this,'startXML'], [$this, 'endXML']);
xml_set_character_data_handler($this->parser, [$this,'charXML']);

// @see https://www.php.net/manual/en/function.xml-parser-set-option.php
xml_parser_set_option($this->parser, XML_OPTION_CASE_FOLDING, false);
Expand Down
Loading