-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create arm + x86 Docker images to allow local builds #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Deployed on https://66c4a46f5f246600881aae1b--pglite.netlify.app |
6a65fc2
to
17a794f
Compare
289d5a5
to
efdea21
Compare
should be good when removing the "patches/exports" file and replacing with : exports/pgcore + imports/pgcore + imports/plpgsql + imports/vector from #206 which allow for agressive shake |
@pmp-p I can wait for your PR to merge and will rebase on your changes to ensure everything's working |
Add docker image build workflow Temporarily disable normal workflow Split lines Quote vars correctly Use GH actions Use correct tags Define env vars up front Add dockerhub credentials to GH action Use build config file Fix PG_VERSION env Try to set the PGVERSION correctly Set PGVERSION correctly Trigger buildkite manually Trigger correct pipeline Check if image exists Rename Disable gh trigger Remove check for existing image Add image check again Echo the buildconfig Try to export parameters Remove top level env vars Set dummy env vars Check if source does anything at all Don't define the env Try a few different exports Double bracket Double bracket not everywhere One more try Use right file name One more try Escape env vars Remove invalid command I think I got it... Do not double escape on the string interpolation It had just worked... Try with double dollars Only trigger from GHA Use env correctly Test cancel buid Re enable regular workflow
Typo in EMFLAVOUR
efdea21
to
a26bad8
Compare
samwillis
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating docker images
pglite-builder
for both arm and x86 machines to enable easy local building of pglite.This work involves both CI + automation for the build as well as sorting out ARM issues with the pglite build.
Added package.json top level script
wasm:build
that spins up the docker image and compiles wasm PGlite and dumps the results inpackages/pglite/release
.Also bumps the SDK and PG versions.