Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create arm + x86 Docker images to allow local builds #198

Merged
merged 6 commits into from
Aug 20, 2024

Conversation

msfstef
Copy link
Collaborator

@msfstef msfstef commented Aug 14, 2024

Creating docker images pglite-builder for both arm and x86 machines to enable easy local building of pglite.

This work involves both CI + automation for the build as well as sorting out ARM issues with the pglite build.

Added package.json top level script wasm:build that spins up the docker image and compiles wasm PGlite and dumps the results in packages/pglite/release.

Also bumps the SDK and PG versions.

@msfstef msfstef temporarily deployed to PGlite Build Parameters August 14, 2024 13:33 — with GitHub Actions Inactive
@msfstef msfstef deployed to PGlite Build Parameters August 14, 2024 13:33 — with GitHub Actions Active
@msfstef msfstef had a problem deploying to PGlite Build Parameters August 14, 2024 13:40 — with GitHub Actions Failure
@msfstef msfstef had a problem deploying to PGlite Build Parameters August 14, 2024 13:43 — with GitHub Actions Failure
@msfstef msfstef had a problem deploying to PGlite Build Parameters August 14, 2024 13:44 — with GitHub Actions Failure
Copy link
Contributor

github-actions bot commented Aug 14, 2024

@msfstef msfstef had a problem deploying to PGlite Build Parameters August 14, 2024 13:50 — with GitHub Actions Failure
@msfstef msfstef had a problem deploying to PGlite Build Parameters August 14, 2024 13:53 — with GitHub Actions Failure
@msfstef msfstef had a problem deploying to PGlite Build Parameters August 14, 2024 13:57 — with GitHub Actions Error
@msfstef msfstef changed the title tmp: Dockerize build feat: Create job for generating Docker image of PGlite builder Aug 14, 2024
@msfstef msfstef force-pushed the msfstef/dockerize-build branch from 6a65fc2 to 17a794f Compare August 19, 2024 07:49
@msfstef msfstef linked an issue Aug 19, 2024 that may be closed by this pull request
@msfstef msfstef changed the title feat: Create job for generating Docker image of PGlite builder feat: Create arm + x86 Docker images to allow local builds Aug 19, 2024
@msfstef msfstef force-pushed the msfstef/dockerize-build branch from 289d5a5 to efdea21 Compare August 20, 2024 07:39
@msfstef msfstef requested review from samwillis and pmp-p August 20, 2024 07:41
@msfstef msfstef marked this pull request as ready for review August 20, 2024 07:41
@pmp-p
Copy link
Collaborator

pmp-p commented Aug 20, 2024

should be good when removing the "patches/exports" file and replacing with : exports/pgcore + imports/pgcore + imports/plpgsql + imports/vector from #206 which allow for agressive shake

@msfstef
Copy link
Collaborator Author

msfstef commented Aug 20, 2024

@pmp-p I can wait for your PR to merge and will rebase on your changes to ensure everything's working

Add docker image build workflow

Temporarily disable normal workflow

Split lines

Quote vars correctly

Use GH actions

Use correct tags

Define env vars up front

Add dockerhub credentials to GH action

Use build config file

Fix PG_VERSION env

Try to set the PGVERSION correctly

Set PGVERSION correctly

Trigger buildkite manually

Trigger correct pipeline

Check if image exists

Rename

Disable gh trigger

Remove check for existing image

Add image check again

Echo the buildconfig

Try to export parameters

Remove top level env vars

Set dummy env vars

Check if source does anything at all

Don't define the env

Try a few different exports

Double bracket

Double bracket not everywhere

One more try

Use right file name

One more try

Escape env vars

Remove invalid command

I think I got it...

Do not double escape on the string interpolation

It had just worked...

Try with double dollars

Only trigger from GHA

Use env correctly

Test cancel buid

Re enable regular workflow
@msfstef msfstef force-pushed the msfstef/dockerize-build branch from efdea21 to a26bad8 Compare August 20, 2024 13:57
@msfstef msfstef merged commit 1de36fe into main Aug 20, 2024
8 checks passed
@msfstef msfstef deleted the msfstef/dockerize-build branch August 20, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local builds using Docker
3 participants