-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New gh action to pnpm i and pnpm build:all #520
Conversation
🚀 Deployed on https://67a3600f41a0230dc1e4b74c--pglite.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, happy to get this in.
We can de-duplacate the work flows later, but having this tested makes sense.
Is it worth adding a pnpm test
at the end, or should we wait till we have this as the main workflow?
Good idea, just added it, will wait for the CI and then merge. |
@samwillis test fail on that action... hm... |
@samwillis Will merge this without running the tests. Made a separate PR for that and will look into fixing it. |
We want to run a CI action that mimics the README.md instructions as close as possible.