Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New gh action to pnpm i and pnpm build:all #520

Merged
merged 10 commits into from
Feb 5, 2025

Conversation

copiltembel
Copy link
Collaborator

We want to run a CI action that mimics the README.md instructions as close as possible.

@copiltembel copiltembel requested a review from samwillis February 4, 2025 15:36
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Copy link
Collaborator

@samwillis samwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, happy to get this in.

We can de-duplacate the work flows later, but having this tested makes sense.

Is it worth adding a pnpm test at the end, or should we wait till we have this as the main workflow?

@copiltembel
Copy link
Collaborator Author

Is it worth adding a pnpm test at the end, or should we wait till we have this as the main workflow?

Good idea, just added it, will wait for the CI and then merge.

@copiltembel
Copy link
Collaborator Author

@samwillis test fail on that action... hm...

@copiltembel
Copy link
Collaborator Author

@samwillis Will merge this without running the tests. Made a separate PR for that and will look into fixing it.

@copiltembel copiltembel merged commit ea110d1 into main Feb 5, 2025
8 checks passed
@copiltembel copiltembel deleted the tudor/installBuildAsReadme branch February 5, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants