Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove support for node 10 #98

Closed
wants to merge 1 commit into from
Closed

Conversation

fcastilloec
Copy link
Collaborator

This will close #94 since we're updating here.

@fcastilloec fcastilloec requested a review from malept May 25, 2021 16:42
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (35faac3) to head (e9a56c2).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #98   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          212       212           
=========================================
  Hits           212       212           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarshallOfSound
Copy link
Member

This is now covered by #196, and has implicitly been true for a while because tmp-promise only supports node 14 and higher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants