Skip to content

Rely on @electron/universal for macOS ASAR integrity #2169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Feb 28, 2025

 ~/D/m/E/Contents  file Resources/app.asar.unpacked/node_modules/keytar/build/Release/keytar.node                                                                                                                       Fri Feb 28 11:53:50 2025
Resources/app.asar.unpacked/node_modules/keytar/build/Release/keytar.node: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit bundle x86_64] [arm64:Mach-O 64-bit bundle arm64]
Resources/app.asar.unpacked/node_modules/keytar/build/Release/keytar.node (for architecture x86_64):	Mach-O 64-bit bundle x86_64
Resources/app.asar.unpacked/node_modules/keytar/build/Release/keytar.node (for architecture arm64):	Mach-O 64-bit bundle arm64
 ~/D/m/E/Contents  file Resources/app.asar.unpacked/node_modules/matrix-seshat/index.node                                                                                                                               Fri Feb 28 11:54:02 2025
Resources/app.asar.unpacked/node_modules/matrix-seshat/index.node: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit dynamically linked shared library x86_64] [arm64]
Resources/app.asar.unpacked/node_modules/matrix-seshat/index.node (for architecture x86_64):	Mach-O 64-bit dynamically linked shared library x86_64
Resources/app.asar.unpacked/node_modules/matrix-seshat/index.node (for architecture arm64):	Mach-O 64-bit dynamically linked shared library arm64

Bumps @electron/universal

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy added the T-Task Tasks for the team like planning label Feb 28, 2025
@t3chguy t3chguy self-assigned this Feb 28, 2025
@t3chguy
Copy link
Member Author

t3chguy commented Feb 28, 2025

Blocking until electron-builder update which brings this in organically rather than by needing a manual resolution

t3chguy added 4 commits March 13, 2025 08:46
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Copy link
Member Author

t3chguy commented Mar 18, 2025

Blocked on electron/universal#130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning X-Blocked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant