Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update incoming call notification content to "📹 Incoming call" #4231

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Feb 4, 2025

Content

Update incoming call notification content to "📹 Incoming call". Do not use the default content anymore.

Motivation and context

Screenshots / GIFs

Before After
Image Image

Tests

  • Get an incoming call in one of your DM and observe the notification which is displayed. It should have the new text.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty added the PR-Misc For other changes label Feb 4, 2025
@bmarty bmarty requested a review from a team as a code owner February 4, 2025 15:23
@bmarty bmarty requested review from jmartinesp and removed request for a team February 4, 2025 15:23
@@ -160,7 +160,8 @@ class DefaultActiveCallManager @Inject constructor(
senderDisplayName = notificationData.senderName ?: notificationData.senderId.value,
roomAvatarUrl = notificationData.avatarUrl,
notificationChannelId = notificationData.notificationChannelId,
timestamp = notificationData.timestamp
timestamp = notificationData.timestamp,
textContent = notificationData.textContent,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is here.

Copy link

sonarqubecloud bot commented Feb 4, 2025

Copy link
Contributor

github-actions bot commented Feb 4, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/z2aZRQ

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.22%. Comparing base (c5f3b34) to head (7878f97).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4231   +/-   ##
========================================
  Coverage    80.21%   80.22%           
========================================
  Files         2043     2043           
  Lines        54095    54113   +18     
  Branches      6569     6570    +1     
========================================
+ Hits         43393    43411   +18     
  Misses        8429     8429           
  Partials      2273     2273           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 6362e01 into develop Feb 4, 2025
30 checks passed
@bmarty bmarty deleted the feature/bma/incomingCallAvatar branch February 4, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants