-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display a bottom sheet to let user confirm the DM creation #4233
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4233 +/- ##
===========================================
+ Coverage 80.22% 80.23% +0.01%
===========================================
Files 2043 2045 +2
Lines 54113 54182 +69
Branches 6570 6576 +6
===========================================
+ Hits 43411 43473 +62
- Misses 8429 8434 +5
- Partials 2273 2275 +2 ☔ View full report in Codecov by Sentry. |
|
Content
To avoid creating DM by mistake, this PR adds a confirmation bottom sheet at the 2 places where a DM can be created.
The dialog is not shown if the DM already exists.
Figma: https://www.figma.com/design/dywzKQvHYxFD1Ncn4a5NkI/PSB-675%3A-Improve-invite-into-a-DM?node-id=12-36886
Motivation and context
Limit DM created by mistake with the wrong user.
Screenshots / GIFs
StartDMConfirmationDialog.mp4
Tests
Try to create a DM and see the confirmation dialog from:
Tested devices
Checklist