Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a bottom sheet to let user confirm the DM creation #4233

Merged
merged 8 commits into from
Feb 5, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Feb 5, 2025

Content

To avoid creating DM by mistake, this PR adds a confirmation bottom sheet at the 2 places where a DM can be created.

The dialog is not shown if the DM already exists.

Figma: https://www.figma.com/design/dywzKQvHYxFD1Ncn4a5NkI/PSB-675%3A-Improve-invite-into-a-DM?node-id=12-36886

Motivation and context

Limit DM created by mistake with the wrong user.

Screenshots / GIFs

StartDMConfirmationDialog.mp4

Tests

Try to create a DM and see the confirmation dialog from:

  • a user profile page
  • the room creation flow

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner February 5, 2025 09:05
@bmarty bmarty requested review from ganfra and removed request for a team February 5, 2025 09:05
Copy link
Contributor

github-actions bot commented Feb 5, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/xEB3Ze

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 89.61039% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.23%. Comparing base (6362e01) to head (1214b20).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
...eatures/createroom/impl/root/CreateRoomRootView.kt 62.50% 2 Missing and 1 partial ⚠️
...oid/features/userprofile/shared/UserProfileView.kt 62.50% 2 Missing and 1 partial ⚠️
...roid/features/createroom/test/FakeStartDMAction.kt 66.66% 1 Missing ⚠️
...x/ui/components/CreateDmConfirmationBottomSheet.kt 97.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4233      +/-   ##
===========================================
+ Coverage    80.22%   80.23%   +0.01%     
===========================================
  Files         2043     2045       +2     
  Lines        54113    54182      +69     
  Branches      6570     6576       +6     
===========================================
+ Hits         43411    43473      +62     
- Misses        8429     8434       +5     
- Partials      2273     2275       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the PR-Misc For other changes label Feb 5, 2025
@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Feb 5, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Feb 5, 2025
@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Feb 5, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Feb 5, 2025
@bmarty bmarty enabled auto-merge February 5, 2025 14:37
Copy link

sonarqubecloud bot commented Feb 5, 2025

@bmarty bmarty merged commit fc96c00 into develop Feb 5, 2025
26 checks passed
@bmarty bmarty deleted the feature/bma/dmCreationConfirmation branch February 5, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants